feat: Add body validation #49
Conversation
gabrielmachin
requested review from
mlvieras,
lauta2912,
MBerguer and
chaba11
as code owners
gabrielmachin
force-pushed
the
feat/Add-body-validation
branch
from
d32a337
to
2d92009
Compare
src/utils/validator.ts
Outdated
There was a problem hiding this comment.
I'd prefer this directory to be named data-schemas or something similar. Opinions?
src/validator/auth.ts
Outdated
| import { errors } from 'config/errors'; | ||
| import { formatZodError } from 'utils/validator'; | ||
|
|
||
| const userSchema = z.object({ |
There was a problem hiding this comment.
| const userSchema = z.object({ | |
| const userCreationSchema = z.object({ |
src/validator/auth.ts
Outdated
| const userSchema = z.object({ | ||
| email: z.string().email({ message: 'Invalid email' }), | ||
| name: z.string(), | ||
| password: z.string().min(1, { message: "Can't be an empty password" }), |
There was a problem hiding this comment.
We should enforce a password with length 10 at least IMO. This should be a configuration I think. Not an environment variable, but it should be centrally defined
src/validator/auth.ts
Outdated
There was a problem hiding this comment.
Should we also export the inferred types for each schema?
There was a problem hiding this comment.
What would we export the inferred types for, it shouldn't be necessary to use them outside of this file right?
There was a problem hiding this comment.
I don't know. I don't think it hurts to export them, they might be needed in a serializer or something.
gabrielmachin
force-pushed
the
feat/Add-body-validation
branch
3 times, most recently
from
120aea4
to
b4af7d7
Compare
src/data-schemas/auth.ts
Outdated
| import { errors } from 'config/errors'; | ||
| import { formatZodError } from 'utils/validator'; | ||
|
|
||
| const passwordLength = 10; |
There was a problem hiding this comment.
| const passwordLength = 10; | |
| const MINIMUM_PASSWORD_LENGTH = 10; |
gabrielmachin
force-pushed
the
feat/Add-body-validation
branch
from
b4af7d7
to
f139500
Compare
NOTION Ticket
Type of change
Description of the change
Description here
Add body validation for login and register endpoints