Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Saver #342

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Added support for Saver #342

merged 1 commit into from
Dec 17, 2024

Conversation

patrick11994
Copy link
Contributor

Saver is transitioning to Opzet, so I have added the Saver url to the Opzet provider list and updated the README. Attempts to fix: #326, #336

⚠️ There is still a problem on my side. Only some requests seem to work. They are all hitting the same URL, eg: https://saver.nl/rest/adressen/4611AR-4, but it looks like most of them are getting blocked. I don't see anything in the logs, so maybe someone can check this at their side? It works sometimes, and I have a few sensors reporting data after a while.

@gerbenp
Copy link

gerbenp commented Dec 17, 2024

Hi Patrick, you can try to force IPv4 maybe. IPv6 is randomly doing strange things at Saver it looks like,

See: robertraaijmakers/com.trashchecker#208 (comment)

@patrick11994
Copy link
Contributor Author

I did some testing locally and it looks like Saver has their IPv6-stuff not right. I will work on a proper solution to force IPv4 for saver...

@xirixiz xirixiz merged commit 0d24557 into xirixiz:main Dec 17, 2024
1 of 2 checks passed
@Mariusthvdb
Copy link

Mariusthvdb commented Dec 17, 2024

Ive added that change manually to the local file, but can not confirm there is progress.
my Papier entity (the only one currently set to happen in 2025 still is not created correctly.
Whats more, the other entities details have disappeared from the card even though the entities seem alright:

(note all empty space to the right of the listed icons...)
Scherm­afbeelding 2024-12-17 om 15 21 26

while the states seem to be there:

Scherm­afbeelding 2024-12-17 om 15 22 51

no errors in the log.

note the card should show as https://community.home-assistant.io/t/garbage-pickup-date-mijnafvalwijzer-nl-custom-component/34631/986?u=mariusthvdb

86857dc2d99dbda82a55d16282d41e5bbb1fe709

update

the old entities in the card just popped back in... maybe it was a cache thing in the HACS repo, rewriting the official download again over my manual edit....
guess I'll better await the release that will contain the merge

@niekniek89
Copy link

Saver works for me!
I deleted the integration, restarted HA, and re-added the integration with the provider "saver" (with a small s).

@Mariusthvdb
Copy link

Saver works for me! I deleted the integration, restarted HA, and re-added the integration with the provider "saver" (with a small s).

can you confirm you see new dates in 2025?

because I also set it up anew, and, after todays last 'restafval' pickup see only 2 more dates left....

Scherm­afbeelding 2024-12-18 om 15 26 25

note the days until collection date isnt set either on these:

Scherm­afbeelding 2024-12-18 om 15 26 32

@niekniek89
Copy link

Yes, i can confirm a date of 2025

image

@Mariusthvdb
Copy link

guess there is more reason than this alone to give it another try....

Scherm­afbeelding 2024-12-18 om 15 30 44

@Mariusthvdb
Copy link

Yes, i can confirm a date of 2025

image

right, I have this now too for 1 trashtype:
guess the Restafval will be set some time later today

btw, did you download those icons manually from Saver? I tried to do that before but they didnt show nicely at all

Scherm­afbeelding 2024-12-18 om 15 42 24

@niekniek89
Copy link

I took the icons from the saver website (made screenshots) and provided the entities with their own icons via customize.yaml.

image

@Mariusthvdb
Copy link

I took the icons from the saver website (made screenshots) and provided the entities with their own icons via customize.yaml.

a right, so they are not icons, but entity_pictures ;-)

yeah, can do that too of course

@Mariusthvdb
Copy link

Mariusthvdb commented Dec 18, 2024

btw, here are exported .png files directly from the .svg files (so not via screenshots)
they have transparent backgrounds so can be easily used in all themes, dark or light

saver-appel-en-blad
saver-papier
saver-petfles-blik-drankpak-pmd
saver-rest-kliko

the original svg files:

saver-appel-en-blad
saver-papier
saver-petfles-blik-drankpak-pmd
saver-rest-kliko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rucphen and possibly Roosendaal to saver
5 participants