-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Enable different entity managers for multiple log entities #44
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,11 +11,10 @@ | |
|
||
namespace Xiidea\EasyAuditBundle\Resolver; | ||
|
||
use Doctrine\Common\Persistence\ManagerRegistry; | ||
use Doctrine\Common\Util\ClassUtils; | ||
use Symfony\Component\EventDispatcher\Event; | ||
use Xiidea\EasyAuditBundle\Events\DoctrineObjectEvent; | ||
use Xiidea\EasyAuditBundle\Events\DoctrineEvents; | ||
use Xiidea\EasyAuditBundle\Events\DoctrineObjectEvent; | ||
|
||
/** Custom Event Resolver Example Class */ | ||
class DoctrineObjectEventResolver implements EventResolverInterface | ||
|
@@ -32,9 +31,9 @@ class DoctrineObjectEventResolver implements EventResolverInterface | |
protected $identity = ['', '']; | ||
|
||
/** | ||
* @var ManagerRegistry | ||
* @var \Doctrine\ORM\EntityManager | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As we also support ODM, we don't want direct dependency with ORM. You can see we remove the dependency in a earlier commit |
||
*/ | ||
protected $doctrine; | ||
protected $manager; | ||
|
||
protected $changeSetGetterMethods = [ | ||
'getEntityChangeSet', | ||
|
@@ -88,6 +87,7 @@ private function initialize(DoctrineObjectEvent $event, $eventName) | |
$this->eventName = $eventName; | ||
$this->event = $event; | ||
$this->entity = $event->getLifecycleEventArgs()->getObject(); | ||
$this->manager = $event->getLifecycleEventArgs()->getObjectManager(); | ||
$this->identity = $this->getSingleIdentity(); | ||
} | ||
|
||
|
@@ -182,22 +182,6 @@ protected function getReflectionClassFromObject($object) | |
*/ | ||
protected function getUnitOfWork() | ||
{ | ||
return $this->getDoctrine()->getManager()->getUnitOfWork(); | ||
} | ||
|
||
/** | ||
* @return ManagerRegistry|object | ||
*/ | ||
protected function getDoctrine() | ||
{ | ||
return $this->doctrine; | ||
} | ||
|
||
/** | ||
* @param ManagerRegistry $doctrine | ||
*/ | ||
public function setDoctrine($doctrine) | ||
{ | ||
$this->doctrine = $doctrine; | ||
return $this->manager->getUnitOfWork(); | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,7 +30,8 @@ | |
"phpunit/phpunit": "^5.0 || ^6.0", | ||
"friendsofsymfony/user-bundle": "^2.0", | ||
"php-coveralls/php-coveralls": "^2.1", | ||
"doctrine/common": ">=2.2 <3.0" | ||
"doctrine/common": ">=2.2 <3.0", | ||
"doctrine/orm": "^2.2" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No dependency should be with ORM |
||
}, | ||
"autoload": { | ||
"psr-4": { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getManagerForClass expect class name not an object