Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add new test to cover lines handling unkown command line options #50

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

bernhardkaindl
Copy link
Collaborator

@bernhardkaindl bernhardkaindl commented Jan 12, 2024

CI: Add new test to cover lines handling unknown command line options

  • Covering the lines which handle unknown command line options is needed in preparation for upcoming changes where the code coverage appears to be behaving strangely.
  • And of course it raises the code coverage a little more.

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f8bafd) 84.90% compared to head (c781292) 85.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   84.90%   85.27%   +0.36%     
==========================================
  Files          15       15              
  Lines        1928     1942      +14     
==========================================
+ Hits         1637     1656      +19     
+ Misses        291      286       -5     
Flag Coverage Δ
python2.7 83.78% <100.00%> (+0.37%) ⬆️
python3.10.13 84.15% <100.00%> (+0.40%) ⬆️
unittest 84.15% <100.00%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 12, 2024

Coverage

Pytest Code coverage comment for Python 2.7
FileStmtsMissCoverMissing
xen-bugtool152329280%77–79, 84, 95, 100–101, 410, 486, 491, 511, 517, 540, 602, 620, 692–693, 707, 711, 726–727, 733–734, 739, 749, 754, 757–760, 766, 771–773, 776–777, 780–781, 784, 825–827, 962–976, 978–987, 1048, 1056, 1173, 1175, 1179–1180, 1204, 1222, 1225–1227, 1230–1234, 1237–1238, 1242–1244, 1250–1256, 1259–1263, 1265–1281, 1284–1292, 1295–1296, 1298, 1300–1301, 1303–1311, 1314, 1316–1319, 1321, 1323–1324, 1358, 1386, 1401, 1409–1410, 1414–1416, 1418, 1425, 1427–1431, 1433, 1463–1465, 1467–1472, 1475–1479, 1483–1484, 1486, 1503–1504, 1506, 1508–1509, 1511–1513, 1515–1522, 1524–1529, 1533–1534, 1536, 1538, 1540, 1556–1557, 1559, 1561–1563, 1566–1567, 1569, 1571–1573, 1576–1577, 1579, 1581–1584, 1587–1597, 1600–1604, 1613, 1626, 1636, 1640, 1675–1677, 1750, 1785, 1824, 1884, 1927, 1930–1931, 1969, 1976, 1982, 1984–1987, 1990–2000, 2091–2093, 2096–2098, 2110, 2129–2131, 2171–2175, 2187, 2205
integration
   __init__.py00100% 
   conftest.py180100% 
   namespace_container.py35197%85
   test_system_load.py180100% 
   test_xenserver_config.py130100% 
   utils.py61493%18, 31, 66, 104
mocks/xen
   __init__.py00100% 
mocks/xen/lowlevel
   __init__.py00100% 
mocks/xen/lowlevel/xc
   __init__.py50100% 
unit
   __init__.py00100% 
   conftest.py28967%34, 36–40, 42–44
   test_dir_list.py110100% 
   test_fs_funcs.py100100% 
   test_load_plugins.py50100% 
   test_main.py115893%186, 263–265, 267–270
   test_output.py640100% 
   test_process_output.py110100% 
   test_xapidb_filter.py190100% 
TOTAL193631483% 

Tests Skipped Failures Errors Time
20 1 💤 0 ❌ 0 🔥 2.205s ⏱️

Copy link

github-actions bot commented Jan 12, 2024

Covering the lines handling unknown command line options
is needed as preparation for upcoming changes where the
code coverage appears to be behaving strangely.

Signed-off-by: Bernhard Kaindl <[email protected]>
@bernhardkaindl bernhardkaindl force-pushed the cover-unknown-option-code branch from aa5fe31 to c781292 Compare January 12, 2024 10:20
@bernhardkaindl bernhardkaindl changed the title CI: Cover lines handling unkown command line options CI: Add new test to cover lines handling unkown command line options Jan 12, 2024
@bernhardkaindl bernhardkaindl merged commit fde54c6 into master Jan 15, 2024
6 checks passed
@bernhardkaindl bernhardkaindl deleted the cover-unknown-option-code branch January 15, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants