Update urlopen() and getoutput() to support Python3 as well #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeraldEV
previously approved these changes
Nov 8, 2023
bernhardkaindl
force-pushed
the
private/bernhardk/py2-py3-six.moves-urllib
branch
2 times, most recently
from
c54b4d6 to
12f8bef
Compare
bernhardkaindl
changed the title
There are many updates ahead until it starts to work on Python3, and for now, let's not cut off Python2 because when we do so, we cannot merge that code to master as it not run on Python2 nor on Python3. To avoid this, this simple compatibility handling allows us to merge to master. Use line-length=108 for formatting by black and isort for fewer reformats Signed-off-by: Bernhard Kaindl <[email protected]>
bernhardkaindl
force-pushed
the
private/bernhardk/py2-py3-six.moves-urllib
branch
from
12f8bef to
8014792
Compare
GeraldEV
approved these changes
Nov 14, 2023
ashwin9390
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.