CA-403717: Make XEN_RT mode additive for entries #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The environment variable `XEN_RT` is used to specify that logs are being collected by an automation tool, which wants *all* data, including that which would not normally be collected / offered. The previous code was hardcoding a set of entries, which meant any new entries added e.g. by a bugtool plugin, were then not being captured, even if they should have been included by default. Fix this by making the code additive, so we simply add any of our predefined entries which are missing from the default set. Signed-off-by: Alex Brett <[email protected]>
MarkSymsCtx
approved these changes
Dec 11, 2024
bernhardkaindl
approved these changes
Dec 11, 2024
|
@alexbrett: JFYI, in case you didn't receive a notification, this is ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The environment variable
XEN_RTis used to specify that logs are being collected by an automation tool, which wants all data, including that which would not normally be collected / offered.The previous code was hardcoding a set of entries, which meant any new entries added e.g. by a bugtool plugin, were then not being captured, even if they should have been included by default.
Fix this by making the code additive, so we simply add any of our predefined entries which are missing from the default set.