Skip to content

Commit

Permalink
CA-392459: Avoid opening /dev/mem when calling biosdevname
Browse files Browse the repository at this point in the history
biosdevname opens /dev/mem to read the $PIR PCI interrupt routing table.
This fails with Secure Boot enabled and causes a warning in the kernel.
log. Since the $PIR PCI interrupt routing table is used for routing PCI
interrupts to ISA IRQs, it is not useful on any modern system so pass
"-x" to biosdevname to avoid this behaviour.

Signed-off-by: Ross Lagerwall <[email protected]>
  • Loading branch information
rosslagerwall authored and bernhardkaindl committed May 9, 2024
1 parent b50d199 commit 6865196
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion xen-bugtool
Original file line number Diff line number Diff line change
Expand Up @@ -1053,7 +1053,7 @@ exclude those logs from the archive.
cmd_output(CAP_NETWORK_STATUS, [EBTABLES, '-L'])
cmd_output(CAP_NETWORK_STATUS, [IPTABLES, '-nvL'])
cmd_output(CAP_NETWORK_STATUS, [BRCTL, 'show'])
cmd_output(CAP_NETWORK_STATUS, [BIOSDEVNAME, '-d'])
cmd_output(CAP_NETWORK_STATUS, [BIOSDEVNAME, '-d', '-x'])
for p in os.listdir('/sys/class/net/'):
if os.path.isdir('/sys/class/net/%s/bridge' % p):
cmd_output(CAP_NETWORK_STATUS, [BRCTL, 'showmacs', p])
Expand Down

0 comments on commit 6865196

Please sign in to comment.