core: Add results directive #3518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarice
requested review from
superlopuh,
math-fehr,
PapyChacal and
kimxworrall
5 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3518 +/- ##
========================================
Coverage 90.34% 90.35%
========================================
Files 465 465
Lines 58340 58459 +119
Branches 5574 5581 +7
========================================
+ Hits 52708 52821 +113
- Misses 4202 4207 +5
- Partials 1430 1431 +1 ☔ View full report in Codecov by Sentry. |
alexarice
force-pushed
the
alexarice/results-directive
branch
from
25f47b6
to
c924b31
Compare
alexarice
changed the base branch from
alexarice/assembly-parse-type
to
alexarice/operands-directive
alexarice
force-pushed
the
alexarice/results-directive
branch
from
c924b31
to
cf252fc
Compare
|
Rebased on top of operands-directive PR, made a shared superclass for the shared functionality, and added a tonne of tests. |
superlopuh
approved these changes
Nov 27, 2024
|
@superlopuh were you happy with the preceding PRs this sits on top of? |
alexarice
force-pushed
the
alexarice/operands-directive
branch
from
147c591
to
ad9ba6b
Compare
alexarice
force-pushed
the
alexarice/results-directive
branch
from
cf252fc
to
e46d8ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a results directive to the assembly format. Very similar to the operands directive (#3507) but is not a
FormatDirective, so must be used as part of atypeorfunctional-typedirective. I wonder if it's worth making a shared subclass for this and the operands directive to deduplicate some code. If so I can rebase on top of that PR.Stacked on #3516. Draft as this needs more tests