core: add functional-type directive #3517
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarice
requested review from
superlopuh,
math-fehr,
PapyChacal and
kimxworrall
5 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3517 +/- ##
==========================================
- Coverage 90.35% 90.31% -0.04%
==========================================
Files 465 465
Lines 58459 58524 +65
Branches 5581 5588 +7
==========================================
+ Hits 52821 52858 +37
- Misses 4207 4235 +28
Partials 1431 1431 ☔ View full report in Codecov by Sentry. |
alexarice
commented
Nov 25, 2024
| "test.functional_type %0, %1 : (i32, i32) -> ()", | ||
| "%0, %1 = test.functional_type %2, %3 : (i32, i32) -> (i32, i32)", | ||
| "%0 = test.functional_type %1 : (i32) -> i32", | ||
| "%0 = test.functional_type : () -> i32", |
There was a problem hiding this comment.
Side note: There's an extra space that gets printed here, which is presumably a bug with one of the operands directives.
There was a problem hiding this comment.
Should be fixed by #3530
alexarice
force-pushed
the
alexarice/functional-type-directive
branch
from
c8bc6f7
to
940bc1a
Compare
|
I've added an extra test to this. This also has given a way to actually trigger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the functional-type directive, which takes two typeable directives as input.
The key difficulty here was dealing with the results, which are usually surrounded by parentheses but don't have to be if there is exactly one result.
Still a draft as this needs more tests, also stacked on #3516.