-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: use nullable getters in ConstraintContext #3503
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3503 +/- ##
==========================================
+ Coverage 90.32% 90.34% +0.01%
==========================================
Files 464 464
Lines 58067 58055 -12
Branches 5561 5550 -11
==========================================
- Hits 52451 52448 -3
+ Misses 4187 4179 -8
+ Partials 1429 1428 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uncontroversial
Paring this PR down until it's clear that ScopedDicts are what we want to use for constraint contexts, reducing changes to just getters being nullable.