Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: use nullable getters in ConstraintContext #3503

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

superlopuh
Copy link
Member

@superlopuh superlopuh commented Nov 22, 2024

Paring this PR down until it's clear that ScopedDicts are what we want to use for constraint contexts, reducing changes to just getters being nullable.

@superlopuh superlopuh added the misc Miscellaneous label Nov 22, 2024
@superlopuh superlopuh self-assigned this Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.34%. Comparing base (150b84b) to head (9318fdf).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3503      +/-   ##
==========================================
+ Coverage   90.32%   90.34%   +0.01%     
==========================================
  Files         464      464              
  Lines       58067    58055      -12     
  Branches     5561     5550      -11     
==========================================
- Hits        52451    52448       -3     
+ Misses       4187     4179       -8     
+ Partials     1429     1428       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change

xdsl/irdl/constraints.py Outdated Show resolved Hide resolved
xdsl/irdl/constraints.py Outdated Show resolved Hide resolved
xdsl/irdl/constraints.py Outdated Show resolved Hide resolved
xdsl/irdl/constraints.py Outdated Show resolved Hide resolved
@superlopuh superlopuh changed the title misc: use ScopedDict in ConstraintContext misc: use nullable getters in ConstraintContext Nov 22, 2024
Copy link
Collaborator

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncontroversial

@superlopuh superlopuh merged commit 4c530f8 into main Nov 22, 2024
15 checks passed
@superlopuh superlopuh deleted the sasha/misc/verification-context branch November 22, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
misc Miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants