Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: make BaseAttr inferrable #3491

Merged
merged 1 commit into from
Nov 20, 2024
Merged

core: make BaseAttr inferrable #3491

merged 1 commit into from
Nov 20, 2024

Conversation

alexarice
Copy link
Collaborator

@alexarice alexarice commented Nov 20, 2024

As discussed in #3477

Fixes #3483

@alexarice alexarice self-assigned this Nov 20, 2024
@alexarice alexarice added the core xDSL core (ir, textual format, ...) label Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.31%. Comparing base (178e3aa) to head (35cfd4d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3491   +/-   ##
=======================================
  Coverage   90.31%   90.31%           
=======================================
  Files         462      462           
  Lines       58039    58066   +27     
  Branches     5562     5563    +1     
=======================================
+ Hits        52417    52445   +28     
  Misses       4188     4188           
+ Partials     1434     1433    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@alexarice alexarice merged commit 746db81 into main Nov 20, 2024
15 checks passed
@alexarice alexarice deleted the alexarice/base-attr-infer branch November 20, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: add inference for BaseAttr constraint when the underlying type has no parameters
2 participants