Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (stream) remove abstract stream read and write operations #3486

Merged
merged 16 commits into from
Nov 20, 2024

Conversation

superlopuh
Copy link
Member

Another incremental change towards getting rid of the stream dialect, now that the definitions are small enough it feels like the right move is to duplicate the definitions, as there's no particular reason for them to be coupled.

@superlopuh superlopuh added the dialects Changes on the dialects label Nov 20, 2024
@superlopuh superlopuh self-assigned this Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.32%. Comparing base (f7088a0) to head (80c3ee6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3486      +/-   ##
==========================================
- Coverage   90.33%   90.32%   -0.01%     
==========================================
  Files         464      464              
  Lines       58026    58043      +17     
  Branches     5556     5557       +1     
==========================================
+ Hits        52415    52429      +14     
- Misses       4185     4187       +2     
- Partials     1426     1427       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Base automatically changed from sasha/stream/assembly-format to main November 20, 2024 17:51
@superlopuh superlopuh merged commit 5603904 into main Nov 20, 2024
15 checks passed
@superlopuh superlopuh deleted the sasha/stream/no-abstract-read-write branch November 20, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants