-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dialects: (stream) simplify constr helper on stream attributes #3473
Conversation
AnyWritableStreamTypeConstr = BaseAttr[WritableStreamType[Attribute]]( | ||
WritableStreamType | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a feeling that this will be the pattern to use until we have defaults for TypeVars
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3473 +/- ##
==========================================
+ Coverage 90.32% 90.33% +0.01%
==========================================
Files 464 464
Lines 58079 58057 -22
Branches 5565 5556 -9
==========================================
- Hits 52458 52446 -12
+ Misses 4188 4185 -3
+ Partials 1433 1426 -7 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If someone is brave at some point, we could also think about auto-generating these constr
helpers
I'm working towards removing the stream dialect, and would like to simplify it as much as possible before copying to both memref_stream and snitch_stream. I don't think the constr overload is pulling its weight, it's much simpler just to provide a shorthand for the BaseAttr constraint, and only return a ParamAttrConstraint from constr.