transformations: Add further csl name hints #3399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3399 +/- ##
==========================================
- Coverage 90.15% 90.15% -0.01%
==========================================
Files 453 455 +2
Lines 57220 57373 +153
Branches 5502 5524 +22
==========================================
+ Hits 51588 51724 +136
- Misses 4176 4193 +17
Partials 1456 1456 ☔ View full report in Codecov by Sentry. |
n-io
commented
Nov 4, 2024
xdsl/transforms/lower_csl_wrapper.py
Outdated
Comment on lines
323
to
327
| import_.result.name_hint = self._get_name_hint(op) | ||
|
|
||
| rewriter.insert_op(ops, InsertPoint.at_start(csl_mod.body.block)) | ||
| rewriter.replace_matched_op([*structs, import_]) | ||
| rewriter.insert_op(structs, InsertPoint.before(op)) | ||
| rewriter.replace_matched_op(import_) |
There was a problem hiding this comment.
This is to prevent the structs from having the same name as the buffer, and the buffer turning into buf_8 for instance, which may be confusing.
dk949
approved these changes
Nov 5, 2024
xdsl/transforms/lower_csl_wrapper.py
Outdated
| @@ -303,6 +306,12 @@ def _make_import_struct(self, import_op: csl_wrapper.ImportOp): | |||
| out_structs.append(csl.ConcatStructOp(out_structs[-1], s)) | |||
| return out_structs | |||
|
|
|||
| def _get_name_hint(self, import_op: csl_wrapper.ImportOp) -> str | None: | |||
There was a problem hiding this comment.
Could this be Path(import_op.module.data.strip("<>" )).stem?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.