bug: Fix cse for FloatData #3396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3396 +/- ##
==========================================
+ Coverage 90.13% 90.14% +0.01%
==========================================
Files 452 452
Lines 57157 57159 +2
Branches 5498 5498
==========================================
+ Hits 51519 51528 +9
+ Misses 4180 4175 -5
+ Partials 1458 1456 -2 ☔ View full report in Codecov by Sentry. |
superlopuh
reviewed
Nov 4, 2024
xdsl/dialects/builtin.py
Outdated
| @@ -636,6 +636,9 @@ def __eq__(self, other: Any): | |||
| math.isnan(self.data) and math.isnan(other.data) or self.data == other.data | |||
| ) | |||
|
|
|||
| def __hash__(self): | |||
| return super().__hash__() | |||
There was a problem hiding this comment.
Does this work? Would cut out the middle man
Suggested change
| return super().__hash__() | |
| return hash(self.data) |
superlopuh
approved these changes
Nov 4, 2024
Co-authored-by: Sasha Lopoukhine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FloatData recently received an
__eq__method to handlenaninequalities. Because of this change, it also needs to provide a__hash__method.