misc: move pdl, sgpu, and wgsl_printer out of experimental #3384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
compor,
AntonLydike,
alexarice,
math-fehr,
PapyChacal,
webmiche and
kayode-gif
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3384 +/- ##
==========================================
- Coverage 90.13% 90.12% -0.01%
==========================================
Files 452 453 +1
Lines 56953 57108 +155
Branches 5468 5490 +22
==========================================
+ Hits 51333 51470 +137
- Misses 4173 4183 +10
- Partials 1447 1455 +8 ☔ View full report in Codecov by Sentry. |
alexarice
approved these changes
Nov 4, 2024
| @@ -13,7 +13,7 @@ | |||
|
|
|||
| pytest.importorskip("wgpu", reason="wgpu is an optional dependency") | |||
|
|
|||
| from xdsl.interpreters.experimental.wgpu import WGPUFunctions # noqa: E402 | |||
| from xdsl.interpreters.wgpu import WGPUFunctions # noqa: E402 | |||
There was a problem hiding this comment.
What's this lint for? Realise it's unchanged but could there be an explanation in the comment
alexarice
changed the title
|
Also fixed title, was slightly confused on how you were manipulating pdfs with xdsl |
lfrenot
pushed a commit
that referenced
this pull request
Nov 4, 2024
These are actually all fairly well-tested, so I think the experimental bit is confusing. Some of the code would probably benefit from being in a different place, but we can worry about that another time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are actually all fairly well-tested, so I think the experimental bit is confusing. Some of the code would probably benefit from being in a different place, but we can worry about that another time.