dialects: (arith) select canonicalization patterns #3368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarice
added
dialects
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3368 +/- ##
==========================================
- Coverage 90.10% 90.10% -0.01%
==========================================
Files 449 449
Lines 56686 56719 +33
Branches 5443 5451 +8
==========================================
+ Hits 51079 51107 +28
- Misses 4168 4170 +2
- Partials 1439 1442 +3 ☔ View full report in Codecov by Sentry. |
superlopuh
approved these changes
Oct 31, 2024
n-io
approved these changes
Oct 31, 2024
Comment on lines
+42
to
+129
| arith.select %x %true %false = %x | ||
| arith.select %x %false %true = %x xor 1 |
There was a problem hiding this comment.
For an i1 result type you may even consider folding the %true %true and %false %false cases if you think they may realistically come up.
There was a problem hiding this comment.
More generally, arith.select %x %y %y should be %y right? I realise I didn't include this as I didn't immediately find it in mlir but it would probably be nice to add
alexarice
force-pushed
the
alexarice/select-canon
branch
from
79cf439
to
fb761d1
Compare
|
Added select x y y = y and rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some simple canonicalization patterns for
arith.select