misc: fix tests that secretly rely on optional dependencies #3361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
AntonLydike,
math-fehr,
PapyChacal and
webmiche
math-fehr
approved these changes
Nov 2, 2024
tests/interactive/test_app.py
Outdated
Comment on lines
30
to
37
| # Mock pyclip_copy for testing | ||
| _copied_text: str | None = None | ||
|
|
||
|
|
||
| def pyclip_copy(text: str) -> None: | ||
| """Mock version of pyclip_copy that stores copied text for inspection during tests""" | ||
| global _copied_text | ||
| _copied_text = text |
There was a problem hiding this comment.
Because pyclip is also an optional dependency, and it would be nice to actually test what the button copies, even if we don't right now. I could add this quickly
There was a problem hiding this comment.
I actually couldn't get this to work, and added a different API instead.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3361 +/- ##
==========================================
+ Coverage 90.09% 90.12% +0.02%
==========================================
Files 447 450 +3
Lines 56578 56809 +231
Branches 5431 5460 +29
==========================================
+ Hits 50975 51197 +222
- Misses 4166 4167 +1
- Partials 1437 1445 +8 ☔ View full report in Codecov by Sentry. |
EdmundGoodman
pushed a commit
to EdmundGoodman/xdsl
that referenced
this pull request
Dec 6, 2024
…ect#3361) Also changes CI-Core to test only the core dev dependencies, letting CI-MLIR check the full coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changes CI-Core to test only the core dev dependencies, letting CI-MLIR check the full coverage