Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Experiments in e-graphs in IR #3113

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from
Draft

[WIP] Experiments in e-graphs in IR #3113

wants to merge 31 commits into from

Conversation

superlopuh
Copy link
Member

@superlopuh superlopuh self-assigned this Aug 29, 2024
Jianyi Cheng and others added 2 commits September 17, 2024 18:08
…ng input example (#3185)

This PR tries to address #3180
* Uncommented non-working examples (which require features from future
PRs
* Minimized the example for swapping inputs
* Formatted the code

---------

Co-authored-by: Jianyi Cheng <[email protected]>
@superlopuh superlopuh marked this pull request as draft October 1, 2024 14:13
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.34%. Comparing base (d9e2fa1) to head (e9cae52).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3113      +/-   ##
==========================================
+ Coverage   90.33%   90.34%   +0.01%     
==========================================
  Files         464      468       +4     
  Lines       58076    58374     +298     
  Branches     5552     5572      +20     
==========================================
+ Hits        52463    52740     +277     
- Misses       4184     4198      +14     
- Partials     1429     1436       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

superlopuh and others added 2 commits November 3, 2024 12:15
- [x] Add initial Python rewrite (for learning & documentation)
- [ ] Add the corresponding PDL rewrite

---------

Co-authored-by: Jianyi Cheng <[email protected]>
Co-authored-by: Sasha Lopoukhine <[email protected]>
):
owner = xdsl_val.owner
assert isinstance(owner, eqsat.EClassOp)
assert (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this will no longer be true after the first rewrite, i.e. an eclass may have more than one operand?

@jianyicheng
Copy link
Collaborator

Not sure if I am looking at the right PR but it seems there is no test on eqsatpdl... Is this expected? @superlopuh Happy to write one by myself if there isn't one.

@superlopuh
Copy link
Member Author

This is the everything PR, it would definitely be useful to add tests, but especially in the PRs that take bits of code from here that we think are ready and merge to main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants