-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(transform): csl-stencil to csl-wrapper pass #2878
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2878 +/- ##
==========================================
+ Coverage 89.85% 89.91% +0.05%
==========================================
Files 399 400 +1
Lines 50171 50312 +141
Branches 7755 7776 +21
==========================================
+ Hits 45083 45237 +154
+ Misses 3860 3847 -13
Partials 1228 1228 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice stuff! Would always love more comments, but the code is already quite a bit more readable than before!
Pass to lower
csl_stencil
tocsl_wrapper
.csl_wrapper.module
for each module-level functioncsl_wrapper.modue
and both of itslayout_module
andprogram_module
regionslayout_module
with everything required for running stencil programs and yields it toprogram_module
, specifically: memcpy params, routes config, andisBorderRegionPE
boolNot in this PR:
Handling host-device transferable symbols and setting up exportsSetting up and exporting program entry pointAs such, the translated func is currently simply placed inside theprogram_module
.Update:
program_module
block argssym_name
is stored as a property on the moduleThe function body is moved into the program module bodycsl.func
named after the translatedfunc.func
, transfer the ops into the new csl main func, and add the function to the program module body