Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transformations: Add memref-stream-tile-outer-loops #2869

Merged
merged 5 commits into from
Jul 10, 2024

Conversation

superlopuh
Copy link
Member

We sometimes have too high a rank when lowering to snitch_stream, this avoids that at the memref_stream level, before streamification.

@superlopuh superlopuh added the transformations Changes or adds a transformatio label Jul 8, 2024
@superlopuh superlopuh self-assigned this Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.85%. Comparing base (05b2fdf) to head (d1ce389).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2869      +/-   ##
==========================================
- Coverage   89.87%   89.85%   -0.02%     
==========================================
  Files         396      397       +1     
  Lines       49827    49950     +123     
  Branches     7683     7712      +29     
==========================================
+ Hits        44780    44883     +103     
- Misses       3837     3848      +11     
- Partials     1210     1219       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xdsl/transforms/memref_stream_tile_outer_loops.py Outdated Show resolved Hide resolved
xdsl/transforms/memref_stream_tile_outer_loops.py Outdated Show resolved Hide resolved
xdsl/transforms/memref_stream_tile_outer_loops.py Outdated Show resolved Hide resolved
xdsl/transforms/memref_stream_tile_outer_loops.py Outdated Show resolved Hide resolved
xdsl/transforms/memref_stream_tile_outer_loops.py Outdated Show resolved Hide resolved
@zero9178
Copy link
Contributor

zero9178 commented Jul 9, 2024

Regarding tests: Really just the most basic kernel would be fine to use here that happens to have more than the given rank of dimensions being used. Having at least one test case where the pattern has to be applied twice (i.e. cut two dimensions in total, one at a time) would be interesting.

Additionally if you address one of the comments: A test where the input memrefs are already strided with an offset (possibly static)

@superlopuh superlopuh requested a review from zero9178 July 10, 2024 11:36
@superlopuh superlopuh merged commit bbacd16 into main Jul 10, 2024
10 checks passed
@superlopuh superlopuh deleted the sasha/memref_stream/tile branch July 10, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
transformations Changes or adds a transformatio
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants