Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Update filecheck to 1.0 #2828

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

AntonLydike
Copy link
Collaborator

@AntonLydike AntonLydike commented Jul 3, 2024

This switches to a new implementation of filecheck that is much more faithful to LLVMs filecheck.

Stacked on top of #2824

@AntonLydike AntonLydike self-assigned this Jul 3, 2024
@AntonLydike AntonLydike added dependencies Pull requests that update a dependency file testing PRs that modify tests labels Jul 3, 2024
@webmiche
Copy link
Collaborator

webmiche commented Jul 3, 2024

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.91%. Comparing base (2555dfd) to head (3550117).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2828   +/-   ##
=======================================
  Coverage   89.91%   89.91%           
=======================================
  Files         400      400           
  Lines       50312    50312           
  Branches     7776     7776           
=======================================
  Hits        45237    45237           
  Misses       3847     3847           
  Partials     1228     1228           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AntonLydike AntonLydike force-pushed the anton/switch-to-filecheck-ng branch 2 times, most recently from 6cfac20 to f83d819 Compare July 15, 2024 12:50
@AntonLydike AntonLydike changed the title tests: Move to filecheck-ng tests: Update filecheck to 1.0 Jul 15, 2024
@AntonLydike
Copy link
Collaborator Author

This now somewhat cleanly encapsulates all the changes necessary to update from filecheck 0.24 to 1.0

Base automatically changed from anton/fix-file-checks to main July 15, 2024 16:24
@AntonLydike AntonLydike merged commit 9b43500 into main Jul 16, 2024
10 checks passed
@AntonLydike AntonLydike deleted the anton/switch-to-filecheck-ng branch July 16, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file testing PRs that modify tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants