Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add extra defensive checks #98

Merged
merged 3 commits into from
Nov 3, 2023
Merged

add extra defensive checks #98

merged 3 commits into from
Nov 3, 2023

Conversation

rpreen
Copy link
Member

@rpreen rpreen commented Nov 3, 2023

Adds extra checks for empty sets before performing operations such as roulette wheel deletion, match set building and set updating -- these should never happen in practice and would segfault if it did --- if this ever does somehow happen, this will gracefully exit with a message; and tries to satisfy the static analysis tools.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (563167b) 61.89% compared to head (2f7b8c4) 61.86%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage   61.89%   61.86%   -0.03%     
==========================================
  Files          62       62              
  Lines        8894     8903       +9     
  Branches     1073     1076       +3     
==========================================
+ Hits         5505     5508       +3     
- Misses       3389     3395       +6     
Files Coverage Δ
xcsf/clset.c 66.66% <33.33%> (-0.82%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

40.0% 40.0% Coverage
0.0% 0.0% Duplication

@rpreen rpreen changed the title add extra defensive checks for things that should never happen add extra defensive checks Nov 3, 2023
@rpreen rpreen merged commit c96161a into master Nov 3, 2023
9 of 11 checks passed
@rpreen rpreen deleted the extra_checks branch November 3, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant