Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[script.xbmc.lcdproc] 4.1.0 #2678

Merged
merged 1 commit into from
Dec 7, 2024
Merged

[script.xbmc.lcdproc] 4.1.0 #2678

merged 1 commit into from
Dec 7, 2024

Conversation

herrnst
Copy link
Member

@herrnst herrnst commented Nov 15, 2024

Description

script.xbmc.lcdproc updated to version 4.1.0 for Python 3.13 compatibility.

No functional changes, but this makes the addon compatible with Python 3.13. Most notably, in Py3.13 the already deprecated telnetlib (which was being used by this addon) was finally removed and so all parts were reworked to use raw sockets instead. Also, there was a SyntaxWarning caused by the way RegEx strings were constructed which turn into SyntaxError Exceptions now, that is also addressed.

From changelog.txt:

  • Python 3.13 compat: Use raw strings for regex'es everywhere, fixes SyntaxError's (thanks alanswanson!)
  • Python 3.13 compat: Replace long deprecated telnetlib usage with raw sockets (thanks m-wichmann!)
  • Minor housekeepings

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [script.foo.bar] 1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practise but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

@romanvm romanvm added the Approved Approved and is ready to merge label Dec 7, 2024
@romanvm romanvm merged commit 95a60f1 into xbmc:matrix Dec 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Approved and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants