Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[script.copacetic.helper 1.0.16] #2619

Merged
merged 1 commit into from
May 25, 2024

Conversation

realcopacetic
Copy link

Description

1.0.16

  • Added tvchannels/radiochannels to background_slideshow()
  • Error handling for clearlogos that aren't in a supported PIL mode Some rare clearlogos are causing the background service to crash realcopacetic/script.copacetic.helper#3
  • Added landscape to movieartwhitelist/tvshowartwhitelist recommended settings
  • SlideshowMonitor class extended to accept custom paths to folders of images e.g. special://profile/backgrounds/ - it can now populate background slideshows sourced from library paths, playlists, plugin sources (e.g. themoviedbhelper) and folders
  • Rebuilt wideget_move() to account for new widget settings

1.0.15

  • Global search action to open keyboard and return value to relevant skin string.
  • Minor error catching in play_all()

1.0.14

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [script.foo.bar] 1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practise but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

@realcopacetic
Copy link
Author

I can't see anything in this PR that would prompt the add-on checker failure. I noticed @ronie pushed a PR yesterday (#2618 (comment)) with the same failure, so I'm not sure if this is an issue with the checker?

@realcopacetic realcopacetic force-pushed the script.copacetic-1.0.16 branch from 82879a0 to b0bd32a Compare May 16, 2024 08:58
@realcopacetic
Copy link
Author

FYI - I just added and squashed a second commit, which is why the version number in the commit is 1.0.17 but the branch name is 1.0.16



class Main:
def __init__(self, *args):
try:
self.params = dict(arg.split('=', 1) for arg in args)
log(f'FUCK_IN: {self.params}', force=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we rename this? We don't want little devs to read foul language 😄

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh sorry haha, thought I had removed that, as you can probably tell I was getting quite frustrated with getting something to work - will remove it asap! Thanks for checking @basrieter

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, updated and squashed - thanks @basrieter

@realcopacetic realcopacetic force-pushed the script.copacetic-1.0.16 branch from 482fc4c to 03d8030 Compare May 25, 2024 16:00
@basrieter basrieter merged commit 0095a22 into xbmc:nexus May 25, 2024
1 check passed
@realcopacetic realcopacetic deleted the script.copacetic-1.0.16 branch May 31, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants