Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix - script.module.libmediathek4 : Handle Timestamps Containing Millseconds Correctly #2589

Closed
wants to merge 2 commits into from

Conversation

obrain17
Copy link

Description

Handle timestamps containing millseconds correctly.
Mainly in German channel "ARD/Das Erste" list creation A-Z stopped with error.
This does not happen anymore because the milliseconds are "cut off" with new code.
Of course also channels without milliseconds still work.

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [script.foo.bar] 1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practise but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

Handle date/time with milliseconds correctly. Channel ARD/Das Erste
Handle date/time with milliseconds correctyl
@basrieter
Copy link
Contributor

Please create a PR in the original source location: https://github.com/sarbes/plugin.video.libmediathek4

Then the add-on maintainer can create an office PR for a Kodi repository release.

@basrieter basrieter closed this Feb 23, 2024
@obrain17
Copy link
Author

The original source cannot be found at https://github.com/sarbes/plugin.video.libmediathek4. Only an older version is there https://github.com/sarbes/script.module.libmediathek4.
I cannot use this for a PR.
@sarbes May I ask you to check this PR ?
or @basrieter can you forward it to sarbes, please

@basrieter
Copy link
Contributor

Yes you can. Fork the repo, make the changes and create a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants