Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service.iptv.manager] 0.2.4+matrix.1 #2569

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

pihug12
Copy link

@pihug12 pihug12 commented Jan 2, 2024

Add-on details:

Description of changes:

v0.2.4 (2023-12-02)

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [script.foo.bar] 1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practise but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

Sorry, something went wrong.

@pkscout pkscout merged commit e7ec857 into xbmc:matrix Jan 26, 2024
1 check passed
@Lunatixz
Copy link

@pihug12 Can you explain the need for this change?

@peno64
Copy link

peno64 commented Jan 26, 2024

@Lunatixz

I can do that.

service.iptv.manager changes the configuration of iptv simple client to be able to work. That has always been so since the beginning of service.iptv.manager
However since Kodi Matrix this didn't work anymore because for some reason the configuration file of iptv simple client now has a different name. This fix searches the new name and adapts that one such that service.iptv.manager works again.

@Lunatixz
Copy link

Lunatixz commented Jan 26, 2024

Changing the settings for another plugin are against repository rules (unless you provide a Yes/No prompt that defaults to No on cancel). You're also not the developer of this script, which is required for PR's; unless the plugin was abandoned. I suggest you contact the original developer for ideas to solve your issue. THX

@peno64
Copy link

peno64 commented Jan 26, 2024

@Lunatixz

Again, it has always been like that from the beginning from this addon as developed from the original developer Michael Arnouts and it has been accepted at that time so why suddenly after that time not accept it. It is the only way how this addon can work.

@Lunatixz
Copy link

Lunatixz commented Jan 26, 2024

@peno64 I understand and IC you have a PR in the origin repository. However, this doesn't change that fact that you're copying files to another plugin; which is against repository guidelines. All changes to another plugins settings from a third-party are to be handled by Kodi's API. ie setsetting('foobar',true) at no point are copying files from one plugin to another allowed. You are also requested to prompt users to apply changes with clear dialog on specific changes.

I will be reverting the PR and making a bump to the version number to facilitate the change.

@Lunatixz
Copy link

@peno64 You might want to keep your eye on this PR xbmc/xbmc#23648

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants