Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[script.plexmod] 0.7.3 #2565

Closed
wants to merge 1 commit into from
Closed

[script.plexmod] 0.7.3 #2565

wants to merge 1 commit into from

Conversation

pannal
Copy link

@pannal pannal commented Dec 24, 2023

Description

PlexMod (for Kodi)
This is a fork of the official open-source Plex client for Kodi "plex-for-kodi" (Plex4Kodi) maintained by me (pannal). The official client was abandoned years ago, this fork is over 800 commits ahead and supports all Kodi versions since Leia/18.

This submission has been agreed upon in advance with Plex Inc's legal team.

Source, Discussion

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [script.foo.bar] 1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practise but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

@pannal pannal changed the title [script.plexmod] 0.7.2 [script.plexmod] 0.7.3-rev2 Dec 31, 2023
@pannal pannal force-pushed the nexus branch 2 times, most recently from 3d35152 to a4b9c84 Compare December 31, 2023 02:10
@romanvm
Copy link
Collaborator

romanvm commented Dec 31, 2023

Please fix version in addon.xml. Also, please do not submit the addon into several branches. New submissions are allowed only into the branch that corresponds to the current Kodi version that is nexus at the moment. Please close all other PRs.

@pannal
Copy link
Author

pannal commented Dec 31, 2023

Hey, I'll fix the version.

According to the wiki new submissions are currently allowed for matrix and nexus (I'll remove the omega PR). Or am I missing something here?

Thanks!

Edit: Ah, I only need to PR against nexus because it's compatible with matrix as well. Got it.

@pannal pannal changed the title [script.plexmod] 0.7.3-rev2 [script.plexmod] 0.7.3 Dec 31, 2023
@romanvm
Copy link
Collaborator

romanvm commented Jan 1, 2024

@pannal Normally, new submissions are allowed only to the current version. Probably the Wiki was not properly updated. But since this is the info that is currently publicly available let's assume its correct. In this case you should submit your PR to matrix branch and your addon will be available in future versions. If you submit it to nexus it won't be available for matrix, unless that is what you want. Also please fix your addon.xml because the news section is too long. And I want to warn you in advance that reviewing this PR will take time because of the sheer volume of the PR and the fact that GH UI is f***ing slow with such big number of files.

@pannal pannal changed the base branch from nexus to matrix January 2, 2024 13:45
@pannal pannal changed the base branch from matrix to nexus January 2, 2024 13:46
@pannal pannal closed this Jan 2, 2024
@pannal pannal mentioned this pull request Jan 2, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants