Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin.video.themoviedb.helper #4602

Merged

Conversation

jurialmunkey
Copy link

Description

Requires xbmc/repo-scripts#2683 to be merged first

Refactors some service methods to separate image monitoring into its own thread and standardise functionality
Add skin level customisation for which properties service monitor retrieves from base listitem
Remove unnecessary JSON RPC workaround for setting resume as fixed upstream
Adjust some artwork retrieval from FanartTV
Update awards data from TVDB

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practice but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.
  • If you see no activity on your PR after a week (so at least one weekend has passed) then please go to the #kodi-dev freenode IRC channel to reach out to the team

@jurialmunkey jurialmunkey force-pushed the nexus.plugin.video.themoviedb.helper branch from 35bab8f to 963a72f Compare December 7, 2024 02:29
@romanvm
Copy link

romanvm commented Dec 7, 2024

Please fix the errors found by addon-checker

@jurialmunkey jurialmunkey force-pushed the nexus.plugin.video.themoviedb.helper branch from 963a72f to aa0f6cd Compare December 7, 2024 22:50
@jurialmunkey
Copy link
Author

Please fix the errors found by addon-checker

@romanvm - Fixed the issue with the PO file. The only other error remaining is because the module dependency needs to go in first.

@romanvm romanvm merged commit a5514ae into xbmc:nexus Dec 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants