Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-on depends library updates #286

Merged
merged 11 commits into from
Mar 30, 2024
Merged

Conversation

AlwinEsch
Copy link
Member

@AlwinEsch AlwinEsch commented Mar 24, 2024

v21.3.5

  • Update depednencies to fix building on apple silicon (gnutls 3.8.4) and binutils on linux (2.41 or higher)

To have newest versions on dependencies and to fix problem on #284

@AlwinEsch AlwinEsch force-pushed the depends-update branch 3 times, most recently from cc4e6b4 to bfe3ee8 Compare March 25, 2024 07:47
@AlwinEsch AlwinEsch force-pushed the depends-update branch 2 times, most recently from f9c2e3c to 9a34d55 Compare March 26, 2024 22:49
@AlwinEsch AlwinEsch changed the title [WIP] add-on depend library updates add-on depends library updates Mar 26, 2024
@AlwinEsch AlwinEsch requested a review from phunkyfish March 26, 2024 22:50
@AlwinEsch
Copy link
Member Author

Should now ready for review

Copy link
Collaborator

@phunkyfish phunkyfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@AlwinEsch
Copy link
Member Author

Should it be becoming a version increase and release or has you planned additional changes on add-on about?

@fuzzard
Copy link

fuzzard commented Mar 29, 2024

Hold off on this. There are serious questions regarding the upstream xz-utils tarballs. See team repo for details

@fuzzard
Copy link

fuzzard commented Mar 29, 2024

Drop the xz-utils bump for now thanks.

@AlwinEsch
Copy link
Member Author

Drop the xz-utils bump for now thanks.

Thanks @fuzzard, dropped the xzutils away.

@phunkyfish
Copy link
Collaborator

Strange, even though we dropped the xz-utils commit builds are still failing on Windows.

-- Using src='https://tukaani.org/xz/xz-5.4.3.tar.xz'
-- [download 100% complete]
-- [download 6% complete]
-- [download 11% complete]
-- [download 13% complete]
-- [download 31% complete]
-- [download 41% complete]
-- [download 46% complete]
-- [download 60% complete]
-- [download 83% complete]
-- [download 100% complete]
-- verifying file...
       file='C:/jenkins-workspace/workspace/binary-addons/kodi-windows-i686-Omega/cmake/addons/build/download/xz-5.4.3.tar.xz'
-- SHA256 hash of
    C:/jenkins-workspace/workspace/binary-addons/kodi-windows-i686-Omega/cmake/addons/build/download/xz-5.4.3.tar.xz
  does not match expected value
    expected: '92177bef62c3824b4badc524f8abcce54a20b7dbcfb84cde0a2eb8b49159518c'
      actual: '3881a256b0e563fc18fc1c47d8c533cdb3a311bac2920f726d01cb2449f00c97'
-- Hash mismatch, removing...

@phunkyfish
Copy link
Collaborator

Ah, maybe it's because the repo has been disabled:

Screenshot 2024-03-30 at 09 00 33

So we can't download it the unaffected tarball.

@AlwinEsch
Copy link
Member Author

Strange, even though we dropped the xz-utils commit builds are still failing on Windows.

Ah, maybe it's because the repo has been disabled:
So we can't download it the unaffected tarball.

No this was already on sunday and monday where I started on DevCon with depends update, the strange was/is, if I build locally it has always worked with sha256, but within CI's it seems to come different one.

This wrong checksum was always equal. In retrospect, this shasum error makes me very thoughtful, not that something is actually being injected with a modified package using evil proxies.

@AlwinEsch
Copy link
Member Author

@phunkyfish have pushed a update to use xz-utils from our mirror, is then 5.4.1 instead of 5.4.3, but as github and his https://tukaani.org/xz no more available should older better.

Due to dangerous condition about versions 5.6.0 or higher and blocked repo now.
@phunkyfish phunkyfish merged commit abe42fd into xbmc:Omega Mar 30, 2024
2 of 8 checks passed
@AlwinEsch AlwinEsch deleted the depends-update branch March 30, 2024 21:05
@AlwinEsch
Copy link
Member Author

Thanks a lot @phunkyfish for the update to version 5.4.3 and the release.

@phunkyfish
Copy link
Collaborator

All the thanks to you @AlwinEsch, I only did the way bits 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants