-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add-on depends library updates #286
Conversation
cc4e6b4
to
bfe3ee8
Compare
f9c2e3c
to
9a34d55
Compare
Should now ready for review |
9a34d55
to
0717b4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
Should it be becoming a version increase and release or has you planned additional changes on add-on about? |
Hold off on this. There are serious questions regarding the upstream xz-utils tarballs. See team repo for details |
Drop the xz-utils bump for now thanks. |
0717b4c
to
4c11259
Compare
Thanks @fuzzard, dropped the xzutils away. |
Strange, even though we dropped the xz-utils commit builds are still failing on Windows.
|
No this was already on sunday and monday where I started on DevCon with depends update, the strange was/is, if I build locally it has always worked with sha256, but within CI's it seems to come different one. This wrong checksum was always equal. In retrospect, this shasum error makes me very thoughtful, not that something is actually being injected with a modified package using evil proxies. |
@phunkyfish have pushed a update to use xz-utils from our mirror, is then 5.4.1 instead of 5.4.3, but as github and his https://tukaani.org/xz no more available should older better. |
fe1fb8f
to
d7519b9
Compare
Due to dangerous condition about versions 5.6.0 or higher and blocked repo now.
d7519b9
to
34e84d0
Compare
Thanks a lot @phunkyfish for the update to version 5.4.3 and the release. |
All the thanks to you @AlwinEsch, I only did the way bits 😉 |
v21.3.5
To have newest versions on dependencies and to fix problem on #284