Fix seek ffmpeg6 #264
Closed
Fix seek ffmpeg6 #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…these points, so m_pkt.pkt.dts is invalid. m_currentPts will be updated when a valid packet is read.
hasAudio/hasVideo should be set based on streams seen. We don't want to wait for a packet to be seen otherwise we go through the hasAudio path even if video packets are coming later
The m_seekStream check was added to avoid IsTransportStreamReady returning false after a stream has started but most recent packet has no valid dts. But this prevents detection of stream changes (e.g. video stream appearing later than audio). Instead we can use the fact m_startTime is set to avoid issue with missing dts in most recent packet
phunkyfish
force-pushed
the
fix-seek-ffmpeg6
branch
3 times, most recently
from
6e72c9a to
fef0f52
Compare
…rt chapters m_currentPts is not currently set after a seek until a suitable packet is read. That may cause issues with chapters, so make sure m_currentPts is valid immediately after a seek.
phunkyfish
force-pushed
the
fix-seek-ffmpeg6
branch
from
fef0f52 to
e9c3581
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off changes in Kodi PR: https://github.com/xbmc/xbmc/pull/23557/commits and https://github.com/xbmc/xbmc/pull/23629/commits
The first commit is ok. The second required removing
UpdateCurrentPTS()which is used for catchup support. Need a better solution for doing the offset for catchup streams.Commits 3,4 and 5 are followups and also OK.
TL;DR; fix commit 2