Improvement: change logic for playlist updates in Party Mode #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current logic ignored playlist updates in Party Mode to avoid flickering. Playlist reloads are handled by updatePartyModePlaylist which are called for each new song in Party Mode. This causes any user triggered playlist change, e.g. adding an item, to be ignored as well. With this change any playlist update again triggers a playlist reload by also calling updatePartyModePlaylist while in Party Mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue reported in this forum post.
Current logic ignored playlist updates in Party Mode to avoid flickering. Playlist reloads are handled by
updatePartyModePlaylistwhich are only called for each new song in Party Mode. This causes also user triggered playlist changes, e.g. by adding an item, to be ignored as well. With this PR any playlist update again triggers a playlist reload by also callingupdatePartyModePlaylistwhile in Party Mode.Summary for release notes
Improvement: change logic for playlist updates in Party Mode