-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UIKit] Inline the UITraitChangeObservable protocol into the classes that implement it. Fixes #20265. #21676
base: main
Are you sure you want to change the base?
[UIKit] Inline the UITraitChangeObservable protocol into the classes that implement it. Fixes #20265. #21676
Conversation
…that implement it. Fixes #20265. This also required fixing: * A bug in the static registrar where we'd ignore the generic parameters in a method when looking for methods implementing an interface. * A bug in the generator where we'd throw You_Should_Not_Call_base_In_This_Method() in some cases where we shouldn't. Also: * Enable nullability and fix any resulting issues. * Clean up some legacy code we don't need anymore. Ref: #19410 (comment) Fixes #20265.
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commit.NET (No breaking changes)✅ API diff vs stable.NET (No breaking changes)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 107 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
This also required fixing:
A bug in the static registrar where we'd ignore the generic parameters in a method
when looking for methods implementing an interface.
A bug in the generator where we'd throw You_Should_Not_Call_base_In_This_Method()
in some cases where we shouldn't.
Also:
Ref: #19410 (comment)
Fixes #20265.