Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated OpenId Android to AndroidX #1227

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

albertb22
Copy link
Contributor

I have updated the OpenId Android package to AndroidX.
I didn't yet update the Sample project for Android.
If this is necessary I will look into it.

@net-foundation-cla
Copy link

net-foundation-cla bot commented Jun 25, 2021

CLA assistant check
All CLA requirements met.

@albertb22
Copy link
Contributor Author

How do i link this pull-request to this issues #1019?

@moljac moljac linked an issue Jun 25, 2021 that may be closed by this pull request
@albertb22
Copy link
Contributor Author

albertb22 commented Aug 26, 2021

@moljac When will this be merged to master and get an updated Xamarin.OpenId.AppAuth.Android package.

Copy link
Member

@moljac moljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AndroidX and GPS-FB-MLKit target MonoAndroid9.0 so please change this until we bump rest

otherwise LGTM

@albertb22
Copy link
Contributor Author

@moljac When will this be reviewed and do you have any idea on when there will be updated Xamarin.OpenId.AppAuth.Android package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenID: does not support Android X
2 participants