Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow big bang release PR #100

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

secobaka
Copy link
Contributor

@secobaka secobaka commented Jul 8, 2024

@onk @motemen
Hello,
I have discovered that unintended behavior occurs during the big bang release typically seen in the early stages of repository setup.

Issue

Due to the checkbox state verification being based on a prefix match of the PR number, when multiple PRs are included, checkboxes may be unintentionally marked for PRs that weren't intended.

// Old Body
- [x] #3 Provides a creating release pull-request object for template @hakobe
- [ ] #6 Support two factor auth @ninjinkun

// New Body
- [ ] #3 Provides a creating release pull-request object for template @hakobe
- [ ] #6 Support two factor auth @ninjinkun
- [ ] #30 Extract logic from bin/git-pr-release @banyan

// Expected 
- [x] #3 Provides a creating release pull-request object for template @hakobe
- [ ] #6 Support two factor auth @ninjinkun
- [ ] #30 Extract logic from bin/git-pr-release @banyan

// Actual
- [x] #3 Provides a creating release pull-request object for template @hakobe
- [ ] #6 Support two factor auth @ninjinkun
- [x] #30 Extract logic from bin/git-pr-release @banyan

Solution

Modify to check for the existence of a space after the PR number.

lib/git/pr/release/util.rb Outdated Show resolved Hide resolved
@onk
Copy link
Collaborator

onk commented Jul 8, 2024

Thank you for the Pull Request.
How about the suggested change?

@secobaka secobaka requested a review from onk July 9, 2024 03:10
@onk onk merged commit 4c547de into x-motemen:master Jul 9, 2024
1 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants