-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Neo4jv5 #92
Neo4jv5 #92
Conversation
…tology-api, especially developer instructions. 2. Added VERSION file and bumped version to 1.4. 3. Updated requirements.txt to use pinned version of Werkzeug, as with hs-ontology-api. 4. Updated ubkg-api-spec.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found that I had to pin the version of Werkzeug, similar to what was done in requirements for hs-ontology-api--i.e.,
# Flask 2.1.3 installs the latest Werkzeug==3.0.0 (released on 9/30/2023) and causing import issues
# Use a pinned version 2.3.7 (the latest release before 3.0.0) to mitigate temporaryly
# Will upgrade Flask to newer version later on across all APIs. 10/3/2023 - Zhou
Werkzeug==2.3.7
@yuanzhou FYI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlanSimmons yes, let's use the pinned version for now. We'll upgrade to newer version of Werkzeug v3 when we also upgrade Flask v3 since Flask uses Werkzeug internally. And we'll likely handle these dependency updates across all the repos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code needs to be added here.
I'm not sure where this should happen. This is a draft PR. Should the code change be in the actual PR to this branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlanSimmons we don't need to worry about updating the main
code for now since the published PyPI package is still working fine and it doesn't change until the next release.
We should pin this dependency version in neo4jv5
branch. Also FYI @ChuckKollar and @kburke if you've noticed the same issue during local build.
…ts list of SABs and includes the specified code in the response (i.e., if code_id = X, the response includes X).
…ts list of SABs and includes the specified code in the response (i.e., if code_id = X, the response includes X).
…pec YAML; started archive of deprecated code
…nts. Updated documentation.
2/2/2024 We'll leave this PR in the draft mode until @AlanSimmons goes over all the differences and reviews the v5 results against the current v4 on DEV/PROD. |
…nfiguration to limit payload size.
…in app.cfg only to set the default for LIMIT.
…s; bumped version to 2.
Add status endpoint
…yHeader Set up nginx to accept X-API-KEY header
…tics/semantic-types/<semantic_type> and semantics/<semantic_type>/subtypes 2. Corrected test scripts.
Bug fixes related to semantics endpoints
…ype>/subtypes 2. Corrected test scripts.
Bug fixes related to semantics/semantic-types/<semantic_type>/subtypes
…ype>/subtypes 2. Corrected test scripts.
Removed references to URL-encoding for parameters
…format; removed "convenience" endpoint descriptions from spec yamls; updated ubkg-api-spec.yaml to differ from dd-api-spec.yaml
… (paths/nodes/edges) format; removed "convenience" endpoint descriptions from spec yamls; updated ubkg-api-spec.yaml to differ from dd-api-spec.yaml
…eo4jv5 and neo4jv5.
…on3.9 Derek furst/setup python3.9
Paths-related endpoints now return in Table result frame format (nodes/edges/paths)
Specify Path object for BULD/VERSION base package
No description provided.