Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neo4jv5 #92

Merged
merged 112 commits into from
Apr 12, 2024
Merged

Neo4jv5 #92

merged 112 commits into from
Apr 12, 2024

Conversation

ChuckKollar
Copy link
Contributor

No description provided.

ChuckKollar and others added 6 commits December 11, 2023 16:50
…tology-api, especially developer instructions.

2. Added VERSION file and bumped version to 1.4.
3. Updated requirements.txt to use pinned version of Werkzeug, as with hs-ontology-api.
4. Updated ubkg-api-spec.yaml
Copy link
Collaborator

@AlanSimmons AlanSimmons Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that I had to pin the version of Werkzeug, similar to what was done in requirements for hs-ontology-api--i.e.,

# Flask 2.1.3 installs the latest Werkzeug==3.0.0 (released on 9/30/2023) and causing import issues
# Use a pinned version 2.3.7 (the latest release before 3.0.0) to mitigate temporaryly
# Will upgrade Flask to newer version later on across all APIs. 10/3/2023 - Zhou
Werkzeug==2.3.7

@yuanzhou FYI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlanSimmons yes, let's use the pinned version for now. We'll upgrade to newer version of Werkzeug v3 when we also upgrade Flask v3 since Flask uses Werkzeug internally. And we'll likely handle these dependency updates across all the repos.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code needs to be added here.

I'm not sure where this should happen. This is a draft PR. Should the code change be in the actual PR to this branch?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlanSimmons we don't need to worry about updating the main code for now since the published PyPI package is still working fine and it doesn't change until the next release.

We should pin this dependency version in neo4jv5 branch. Also FYI @ChuckKollar and @kburke if you've noticed the same issue during local build.

@yuanzhou
Copy link
Contributor

yuanzhou commented Feb 2, 2024

2/2/2024
The Python neo4j v5 driver update work made in the neo4jv5 branch is done. There's a corresponding PR x-atlas-consortia/hs-ontology-api#79 which upgrades to Python neo4j driver to v5 and uses the changes made here as a dependency package.

We'll leave this PR in the draft mode until @AlanSimmons goes over all the differences and reviews the v5 results against the current v4 on DEV/PROD.

kburke and others added 26 commits March 4, 2024 14:08
…yHeader

Set up nginx to accept X-API-KEY header
…tics/semantic-types/<semantic_type> and semantics/<semantic_type>/subtypes 2. Corrected test scripts.
Bug fixes related to semantics/semantic-types/<semantic_type>/subtypes
Removed references to URL-encoding for parameters
…format; removed "convenience" endpoint descriptions from spec yamls; updated ubkg-api-spec.yaml to differ from dd-api-spec.yaml
… (paths/nodes/edges) format; removed "convenience" endpoint descriptions from spec yamls; updated ubkg-api-spec.yaml to differ from dd-api-spec.yaml
Paths-related endpoints now return in Table result frame format (nodes/edges/paths)
Specify Path object for BULD/VERSION base package
@yuanzhou yuanzhou mentioned this pull request Apr 12, 2024
@yuanzhou yuanzhou marked this pull request as ready for review April 12, 2024 17:34
@yuanzhou yuanzhou merged commit 0385b55 into dev-integrate Apr 12, 2024
4 checks passed
@yuanzhou yuanzhou deleted the neo4jv5 branch April 12, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P Pitt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants