Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.13 #640

Merged
merged 11 commits into from
Sep 29, 2024
Merged

Add support for Python 3.13 #640

merged 11 commits into from
Sep 29, 2024

Conversation

cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Sep 26, 2024

  • Fix DeprecationWarning for typing._collect_parameters. The private function was renamed to _collect_type_parameters in Python 3.13.
  • Add Python 3.13 classifier
  • Update Github actions including cibuildwheel to build wheels for 3.13 by default
  • Fix various smaller issues to get the CI / CD pipeline running again

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.09%. Comparing base (d48cc01) to head (dfac24d).

Files with missing lines Patch % Lines
apischema/typing.py 50.00% 1 Missing ⚠️
apischema/utils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #640   +/-   ##
=======================================
  Coverage   88.09%   88.09%           
=======================================
  Files          62       62           
  Lines        5663     5663           
  Branches     1170     1170           
=======================================
  Hits         4989     4989           
  Misses        460      460           
  Partials      214      214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cdce8p
Copy link
Contributor Author

cdce8p commented Sep 26, 2024

@wyfo Would you mind taking a look at this one? I decided to do all of these changes in a single PR to avoid having to merge and rebase multiple different ones.

@wyfo
Copy link
Owner

wyfo commented Sep 26, 2024

Thank you very much! I planned to tackle 3.13 support this weekend, and I'm more than happy to have your PR to start! A single PR is perfectly fine.

@wyfo wyfo merged commit f3de16a into wyfo:master Sep 29, 2024
11 of 14 checks passed
@cdce8p cdce8p deleted the python-3.13 branch September 29, 2024 23:30
@cdce8p
Copy link
Contributor Author

cdce8p commented Sep 30, 2024

@wyfo Would you mind doing a new release? It would be awesome to have compiled wheels ready in time for the 3.13 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants