Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Add brief doc on how reservations work #4798

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

joaquinco
Copy link
Collaborator

Add howto reservations work.

doc/HOWTO_reservations.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@LeticiaErrandonea LeticiaErrandonea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this! Very appreciated to have more info that can be handy for future devs (or even our future selves).

As a general comment, I think the paragraphs should be a single line in the file, so there aren't predefined newlines in the middle of the sentences. This is also a problem in lines 53-54, where the header is split

doc/HOWTO_reservations.md Outdated Show resolved Hide resolved
doc/HOWTO_reservations.md Outdated Show resolved Hide resolved
@joaquinco
Copy link
Collaborator Author

@LeticiaErrandonea I would keep short lines, they are easier to read from source and don't affect the markdown rendering.

Copy link
Collaborator

@LeticiaErrandonea LeticiaErrandonea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, left a few more comments

it as part of its items.
Instruments are a type of Product which whose usage can be purchased by users
through Reservations. So whenever a new reservation is created, an order is
created or updated to include the Instrument as part of its items with a cost
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

item is a type of product 😅

Maybe we can say So whenever a new reservation is created, an order is created or updated to include the Instrument as part of its items order details?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

pricing policy which can be one of three types:

1. Schedule Rule: charge per minute with fixed rate.
2. Duration: charge per minute with a layered rate depending on the duration.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: usually we refer to it as "stepped" rate

3. Schedule Rule (Daily Booking): charged per day with fixed rate.

The first two allow reservations to be defined on a per minute basis while the
third one is done in 24 hours blocks.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 24-hour blocks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants