-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chore] Add brief doc on how reservations work #4798
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this! Very appreciated to have more info that can be handy for future devs (or even our future selves).
As a general comment, I think the paragraphs should be a single line in the file, so there aren't predefined newlines in the middle of the sentences. This is also a problem in lines 53-54, where the header is split
@LeticiaErrandonea I would keep short lines, they are easier to read from source and don't affect the markdown rendering. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, left a few more comments
doc/HOWTO_reservations.md
Outdated
it as part of its items. | ||
Instruments are a type of Product which whose usage can be purchased by users | ||
through Reservations. So whenever a new reservation is created, an order is | ||
created or updated to include the Instrument as part of its items with a cost |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
item
is a type of product 😅
Maybe we can say So whenever a new reservation is created, an order is created or updated to include the Instrument as part of its items order details?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense
doc/HOWTO_reservations.md
Outdated
pricing policy which can be one of three types: | ||
|
||
1. Schedule Rule: charge per minute with fixed rate. | ||
2. Duration: charge per minute with a layered rate depending on the duration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: usually we refer to it as "stepped" rate
doc/HOWTO_reservations.md
Outdated
3. Schedule Rule (Daily Booking): charged per day with fixed rate. | ||
|
||
The first two allow reservations to be defined on a per minute basis while the | ||
third one is done in 24 hours blocks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: 24-hour blocks
Add howto reservations work.