[#162225] Multi-Facility - Duplicates being created #4189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giladshanan
requested changes
Apr 18, 2024
app/forms/add_to_order_form.rb
Outdated
| @@ -31,6 +31,7 @@ def save | |||
|
|
|||
| if @original_order.facility.id == @facility_id | |||
| add_to_order! | |||
| return true | |||
| end | |||
|
|
|||
| return true unless SettingsHelper.feature_on?(:cross_core_projects) | |||
There was a problem hiding this comment.
I think I'd prefer to wrap the feature flagged changes in a conditional, instead of using a guard clause:
if SettingsHelper.feature_on?(:cross_core_projects)
if order_for_selected_facility.nil?
create_cross_core_project_and_add_order!
else
add_to_order!
end
end
... then we can still git true on line 45.
This would be easier to read and clearer what needs to happen when we are ready to remove the flag.
giladshanan
reviewed
Apr 18, 2024
app/forms/add_to_order_form.rb
Outdated
| create_cross_core_project_and_add_order! | ||
| else | ||
| add_to_order! | ||
| if SettingsHelper.feature_on?(:cross_core_projects) |
There was a problem hiding this comment.
@LeticiaErrandonea maybe this should be elsif?
giladshanan
approved these changes
Apr 29, 2024
diebas
pushed a commit
that referenced
this pull request
Dec 5, 2024
* Fix bug and add spe * Solve one accessibility problem * Improve code * Fix bug * Use elsif
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
Additional Context
Add a spec to add to facility order using Feature Flag.
New spec failed with old code as it found two "Make a reservation" buttons.
Accessibility