-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Endpoints Documentation with rswag
#194
Merged
juanarias93
merged 15 commits into
develop
from
juan_arias--add_endpoints_documentation
Nov 12, 2023
Merged
Add Endpoints Documentation with rswag
#194
juanarias93
merged 15 commits into
develop
from
juan_arias--add_endpoints_documentation
Nov 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanarias93
changed the title
Add Endpoints Documentation with
[DRAFT] Add Endpoints Documentation with Oct 25, 2023
rswag
rswag
juanarias93
changed the title
[DRAFT] Add Endpoints Documentation with
[WIP] Add Endpoints Documentation with Oct 25, 2023
rswag
rswag
juanarias93
force-pushed
the
juan_arias--add_endpoints_documentation
branch
6 times, most recently
from
November 8, 2023 21:28
28fdf6d
to
057aa2e
Compare
* bundle exec rails g rswag:api:install * bundle exec rails g rswag:ui:install * RAILS_ENV=test bundle exec rails g rswag:specs:install
juanarias93
force-pushed
the
juan_arias--add_endpoints_documentation
branch
from
November 11, 2023 17:26
91a0045
to
8ca4c79
Compare
juanarias93
changed the title
[WIP] Add Endpoints Documentation with
Add Endpoints Documentation with Nov 11, 2023
rswag
rswag
andresconti
approved these changes
Nov 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blind approve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What && Why
Add Swagger-based
rswag
gem for documenting BE endpoints.Disclaimers / Extra comments
Documentation will be accessible via UI on: http://localhost:3000/api-docs (or for example on https://finder-backend-qa.onrender.com/api-docs for the QA environment).
Run
SWAGGER_DRY_RUN=0 RAILS_ENV=test rails rswag
in order to re-generate theswagger.json
file.Important: Generated documentation takes into account only the
success
scenarios, enough for hitting the application endpoints properly. Eventually, the rest of the tests/docs can be added, if needed.Coverage was not affected, since this only added some extra specs under
spec/api/
for the endpoints documentation. We're still at98.45%
.How
rswag
gem.spec/api/
for all controllers.swagger.json
file with all endpoint's docs.Links
How to Review
Screenshots
Screen-recording
Screen.Recording.2023-11-10.at.8.55.44.PM.mov