-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Authenticate User for Each Action #150
[Refactor] Authenticate User for Each Action #150
Conversation
00af2b5
to
61fce6c
Compare
61fce6c
to
f785817
Compare
@andresconti ya dejé el otro refactor pronto en #152. Salí de esta branch así tenía lo de la autenticación ya pronta y nos ahorrábamos conflictos después. |
Ahi fueron los cambios 💪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tremendo! 👏
Un par de comentarios chotos.. pero ya está para aprobar.
(por las dudas yo no voy a poder aprobarlo porque soy el autor del PR jeje)
Me dejo aprobarlo ajaj, me tome el atrevimiento de mergearlo despues de agregar los ultimos cambios de los comment |
Co-authored @andresconti & @nodescanses.
What && Why
Require user to be authenticated on each action, except for
signup
andsignin/login
.How
current_user.id
is the same as the/user/:id
, for all actions onUsersController
.HomeController
removing thejson
response, since now it will require authentication.Links
How to Review
Screenshots