Skip to content

Commit

Permalink
Merge pull request #18 from wwt/certified_update
Browse files Browse the repository at this point in the history
bugfix to support cisco.meraki version 2.18.1
  • Loading branch information
nsthompson authored May 31, 2024
2 parents 8506de3 + e75a913 commit c0753b9
Show file tree
Hide file tree
Showing 5 changed files with 25 additions and 13 deletions.
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -162,4 +162,4 @@ scratch/
# option (not recommended) you can uncomment the following to ignore the entire idea folder.
#.idea/

changelogs/.plugin_cache.yaml
changelogs/.plugin-cache.yaml
14 changes: 12 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@

**Topics**

- <a href="#v1-1-3">v1\.1\.3</a>
- <a href="#bugfixes">Bugfixes</a>
- <a href="#v1-1-2">v1\.1\.2</a>
- <a href="#breaking-changes--porting-guide">Breaking Changes / Porting Guide</a>
- <a href="#bugfixes">Bugfixes</a>
- <a href="#bugfixes-1">Bugfixes</a>
- <a href="#v1-1-1">v1\.1\.1</a>
- <a href="#minor-changes">Minor Changes</a>
- <a href="#breaking-changes--porting-guide-1">Breaking Changes / Porting Guide</a>
Expand All @@ -13,6 +15,14 @@
- <a href="#new-plugins">New Plugins</a>
- <a href="#lookup">Lookup</a>

<a id="v1-1-3"></a>
## v1\.1\.3

<a id="bugfixes"></a>
### Bugfixes

* configure\_meraki\_mx \- Fixed VLAN provisioning to match requirements with cisco\.meraki collection version 2\.18\.1

<a id="v1-1-2"></a>
## v1\.1\.2

Expand All @@ -21,7 +31,7 @@

* manage\_meraki\_network \- updated data model so that tags are now a list

<a id="bugfixes"></a>
<a id="bugfixes-1"></a>
### Bugfixes

* configure\_meraki\_mt \- fixed conditional preventing lookup dictionary creation
Expand Down
8 changes: 8 additions & 0 deletions changelogs/changelog.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,11 @@ releases:
- v1.1.2-breaking.yaml
- v1.1.2-bugfixes.yaml
release_date: '2024-05-31'
1.1.3:
changes:
bugfixes:
- configure_meraki_mx - Fixed VLAN provisioning to match requirements with cisco.meraki
collection version 2.18.1
fragments:
- v1.1.3-bugfixes.yaml
release_date: '2024-05-31'
4 changes: 2 additions & 2 deletions galaxy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace: wwt
name: meraki

# The version of the collection. Must be compatible with semantic versioning
version: 1.1.2
version: 1.1.3

# The path to the Markdown (.md) readme file. This path is relative to the root of the collection
readme: README.md
Expand Down Expand Up @@ -44,7 +44,7 @@ tags:
# collection label 'namespace.name'. The value is a version range
# L(specifiers,https://python-semanticversion.readthedocs.io/en/latest/#requirement-specification). Multiple version
# range specifiers can be set and are separated by ','
dependencies: { cisco.meraki: ">=2.18.0" }
dependencies: { cisco.meraki: ">=2.18.1" }
# The URL of the originating SCM repository
repository: https://github.com/wwt/meraki_collection

Expand Down
10 changes: 2 additions & 8 deletions roles/configure_meraki_mx/tasks/configure_vlans.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,6 @@

#
# First pass configuration throws the following errors when run
# when vlanId parameter is omitted:
# Error: Appliance.getNetworkApplianceVlan() missing 1 required positional argument: 'vlanId'
#
# When vlanId parameter is present:
# Error: An error occured when executing operation.
# The error was: appliance, getNetworkApplianceVlan - 404 Not Found, please wait a minute if the key or org was just newly created.
#
# VLANs are provisioned correctly regardless of error as noted above
Expand All @@ -32,7 +27,6 @@
state: "{{ vlan.state }}"
networkId: "{{ network_id }}"
id: "{{ vlan.id }}"
vlanId: "{{ vlan.id }}"
name: "{{ vlan.name | default(omit) }}"
subnet: "{{ vlan.subnet | default(omit) }}"
applianceIp: "{{ vlan.appliance_ip | default(omit) }}"
Expand All @@ -46,7 +40,7 @@
meraki_api_key: "{{ auth_key }}"
state: "{{ vlan.state }}"
networkId: "{{ network_id }}"
vlanId: "{{ vlan.id }}"
id: "{{ vlan.id }}"
name: "{{ vlan.name | default(omit) }}"
reservedIpRanges: "{{ vlan.reserved_ip_range | default(omit) }}"
fixedIpAssignments: "{{ vlan.fixed_ip_assignments | default(omit) }}"
Expand All @@ -66,7 +60,7 @@
meraki_api_key: "{{ auth_key }}"
state: "{{ vlan.state }}"
networkId: "{{ network_id }}"
vlanId: "{{ vlan.id }}"
id: "{{ vlan.id }}"
name: "{{ vlan.name | default(omit) }}"
subnet: "{{ vlan.subnet | default(omit) }}"
applianceIp: "{{ vlan.appliance_ip | default(omit) }}"
Expand Down

0 comments on commit c0753b9

Please sign in to comment.