Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving documentation #215

Merged
merged 3 commits into from
Nov 4, 2022
Merged

Improving documentation #215

merged 3 commits into from
Nov 4, 2022

Conversation

Richard-Gist
Copy link
Collaborator

@Richard-Gist Richard-Gist commented Nov 4, 2022 •
edited
Loading

Linked Issue:

No linked issue, but I noticed these things in the documentation.

Checklist:

@Richard-Gist Richard-Gist marked this pull request as ready for review November 4, 2022 19:18
@Richard-Gist Richard-Gist requested a review from a team as a code owner November 4, 2022 19:18
@Richard-Gist
Copy link
Collaborator Author

I guess since docs are in .github then you need a memeber of wwt/workflow-pipeline to approve. Might need an admin to override and merge.

Additionally, I think the upload of Codecov failed because this is a fork merge? But I could be wrong and it's related to issue #206

@Tyler-Keith-Thompson
Copy link
Collaborator

Using admin privileges to merge this, as it contains no breaking changes.

@Tyler-Keith-Thompson Tyler-Keith-Thompson added the documentation Improvements or additions to documentation label Nov 4, 2022
@Tyler-Keith-Thompson Tyler-Keith-Thompson merged commit cb8c51f into wwt:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyler-Keith-Thompson Tyler-Keith-Thompson Tyler-Keith-Thompson approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Richard-Gist @Tyler-Keith-Thompson