Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upping version of SwiftSyntax in the CLI to lastest. #202

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

morganzellers
Copy link
Contributor

Linked Issue: #201

Checklist:

Copy link
Collaborator

@Tyler-Keith-Thompson Tyler-Keith-Thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires consumers to have Swift 5.6, why would we place that restriction on them?

@morganzellers
Copy link
Contributor Author

Testing these changes as local packages fixed the problems seen in the issue. Not sure what the difference is, but the version we were using was a handful of months behind. The release page mentions vending the internal parser library as a binary framework on macOS, but 🤷🏻.

@morganzellers
Copy link
Contributor Author

This requires consumers to have Swift 5.6, why would we place that restriction on them?

Ah, yeah I didn't consider that.

@codecov-commenter
Copy link

Codecov Report

Merging #202 (5cf9630) into main (671a5a6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #202   +/-   ##
=======================================
  Coverage   90.61%   90.61%           
=======================================
  Files         110      110           
  Lines        2718     2718           
=======================================
  Hits         2463     2463           
  Misses        255      255           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 424df33...5cf9630. Read the comment docs.

Copy link
Collaborator

@Tyler-Keith-Thompson Tyler-Keith-Thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the understanding that this change took us from "it doesn't work" to "it works" I think accepting Swift 5.6 makes sense.

@Tyler-Keith-Thompson Tyler-Keith-Thompson merged commit 8d92e87 into main Apr 11, 2022
@Tyler-Keith-Thompson Tyler-Keith-Thompson deleted the swift-syntax-updates branch April 11, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants