Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov report on README is lying #206

Open
1 task done
Tyler-Keith-Thompson opened this issue Jun 12, 2022 · 3 comments · Fixed by #218
Open
1 task done

Codecov report on README is lying #206

Tyler-Keith-Thompson opened this issue Jun 12, 2022 · 3 comments · Fixed by #218
Labels
good first issue Good for newcomers

Comments

@Tyler-Keith-Thompson
Copy link
Collaborator

What happened?

Our codecov badge says 0% coverage but we have something like 90% coverage

Version

5.1.4 and 5.1.5

Relevant code sample

None

Relevant log output

None

Code of Conduct

  • I agree to follow this project's Code of Conduct
@morganzellers morganzellers added the good first issue Good for newcomers label Jun 21, 2022
@Richard-Gist Richard-Gist linked a pull request Nov 5, 2022 that will close this issue
3 tasks
@Richard-Gist Richard-Gist mentioned this issue Nov 5, 2022
3 tasks
@Tyler-Keith-Thompson
Copy link
Collaborator Author

Re-opening. As it still reports 0%...but when you click on it, it's higher???

@Tyler-Keith-Thompson
Copy link
Collaborator Author

@Richard-Gist
Copy link
Collaborator

The problem is that the upload is not including the code coverage report. Here's the uploaded coverage reports:

<<<<<< network
# path=coverage-report-SwiftCurrent.json
{"coverage":{}}<<<<<< EOF
# path=.github/fastlane/report.xml
<?xml version="1.0" encoding="UTF-8"?>
<testsuites>
  <testsuite name="fastlane.lanes">
    
    
    
      
      <testcase classname="fastlane.lanes" name="0: Verifying fastlane version" time="0.10954">
        
      </testcase>
    
      
      <testcase classname="fastlane.lanes" name="1: default_platform" time="0.001482">
        
      </testcase>
    
      
      <testcase classname="fastlane.lanes" name="2: clear_derived_data" time="0.041685">
        
      </testcase>
    
      
      <testcase classname="fastlane.lanes" name="3: scan" time="605.403753">
        
      </testcase>
    
  </testsuite>
</testsuites>
<<<<<< EOF

I'm not sure why I can't get it to pick up the .xcresult file that has the coverage. Looks like this all broke in the upgrade from 1.5 to 3.0.0. Perhaps we missed these steps when doing the update: https://github.com/codecov/codecov-action#migration-from-v1-to-v3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants