Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add strobealign to mappers in help #214

Merged
merged 14 commits into from
Jun 12, 2024
Merged

add strobealign to mappers in help #214

merged 14 commits into from
Jun 12, 2024

Conversation

AroneyS
Copy link
Collaborator

@AroneyS AroneyS commented May 31, 2024

Closes #186

@wwood
Copy link
Owner

wwood commented Jun 10, 2024

Hey,

The OSX one seems to be failing because of conda package issues (transient? There didn't seem to be an issue before), but the x86 tests are failing because of an issue that was introduced/discovered in this branch:

---- tests::test_sharded_contig_input_reads stdout ----
thread 'tests::test_sharded_contig_input_reads' panicked at /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/assert_cli-0.6.3/src/assert.rs:441:13:
Assertion failed for `cargo run --quiet -- contig -c tests/data/7seqs.reads_for_7.1.fq tests/data/7seqs.reads_for_7.2.fq -r tests/data/shard1.fna tests/data/shard2.fna --sharded`
with: Unexpected stdout

with: Didn't match.
diff=
`` Contig	shard1.fna|shard2.fna/7seqs.reads_for_7.1.fq|7seqs.reads_for_7.1.fq Mean
-genome3~random_sequence_length_11001	0.11057869
genome4~random_sequence_length_11002	0.11056851
genome5~seq2	0
genome6~random_sequence_length_11003	0.110558316
genome1~random_sequence_length_11000	0.109943785
genome1~random_sequence_length_11010	0.110487066
genome2~seq1	0
+genome3~random_sequence_length_11001
	0.11057869
genome4~random_sequence_length_11002
	0.11056851
genome5~seq2
	0
genome6~random_sequence_length_11003
	0.110558316
genome1~random_sequence_length_11000
	0.109943785
genome1~random_sequence_length_11010
	0.110487066
genome2~seq1
	0 

I think that somehow the strobealign sequence IDs have a newline in them, so it messes up the table structure. So maybe a strip() needs to be put in somewhere?

seems to happen with strobealign for some reason
@AroneyS
Copy link
Collaborator Author

AroneyS commented Jun 11, 2024

Yeh, that's the odd error that I sent. I think I've fixed it at the printing stage (print_dense_cached_coverage_taker).
Do I also need to fix it in print_sparse_cached_coverage_taker?

@wwood
Copy link
Owner

wwood commented Jun 11, 2024

I think so, yeh

@wwood wwood merged commit f79a354 into main Jun 12, 2024
2 of 4 checks passed
@wwood wwood deleted the fix-mapping-help branch June 12, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for strobealign
2 participants