Rename UserEntity.webauthnUserHandle to uuid and use it instead of DID where possible #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we use the DID of the user account's public key as a canonical identifier for the account. For "phase 1" of wwWallet/wallet-ecosystem#62, user accounts will no longer have only a single key pair per account, but multiple key pairs, so there will no longer be a canonical key whose DID to use. Instead, we can take the UUID that we currently use only as the WebAuthn user handle and use that as a canonical identifier for the account.
This only changes the application layer - the database schema remains unchanged, so this should be forward- and backwards compatible with earlier versions of the app.
This depends on:
This is mutually dependent on: