customObject implementation #182
Conversation
|
|
||
| project 'PowerAuth' | ||
|
|
||
| target 'PowerAuth' do | ||
| config = use_native_modules! | ||
| use_react_native!( | ||
| :path => config[:reactNativePath] | ||
| :path => config[:reactNativePath], | ||
| :hermes_enabled => false |
There was a problem hiding this comment.
Just comment here: this causes problem with the latest release and our integration and is only for our internal purposes, so disabled.
There was a problem hiding this comment.
Could you describe the source of the problems? I was using "testapp" project only, for the development workflows. If I remember this correctly, then opening the standalone project was pain in the ass in recent RN stack, for both platforms. Using the "testapp" project was much better.
There was a problem hiding this comment.
Hermes is a Facebook-made javascript engine tailored for react native and brings faster startup times.
Basically, for a final build (when compiled), it improves performance but also brings many dependencies that need to be maintained and fixed when broken.
Since we use this only for our test projects and test apps, it's not needed.
Test projects for iOS and the test app still work but with the default js engine, not the Hermes.
|
|
||
| project 'PowerAuth' | ||
|
|
||
| target 'PowerAuth' do | ||
| config = use_native_modules! | ||
| use_react_native!( | ||
| :path => config[:reactNativePath] | ||
| :path => config[:reactNativePath], | ||
| :hermes_enabled => false |
There was a problem hiding this comment.
Could you describe the source of the problems? I was using "testapp" project only, for the development workflows. If I remember this correctly, then opening the standalone project was pain in the ass in recent RN stack, for both platforms. Using the "testapp" project was much better.
kober32
dismissed
hvge’s stale review
The issue was addressed and confirmed by the 2nd reviewer and the customer is waiting for the release.
Resolves #181
react-nativeversion.This change should be released as 2.5.0
react-native-powerauth-mobile-sdk-2.5.0.tgz