Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #278: Executable war #280

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Fix #278: Executable war #280

merged 1 commit into from
Oct 24, 2023

Conversation

jnpsk
Copy link
Contributor

@jnpsk jnpsk commented Oct 24, 2023

  • Standalone profile removed
  • Use dependencyManagement instead of Exclusion

@jnpsk jnpsk requested review from banterCZ and jandusil October 24, 2023 08:26
banterCZ
banterCZ approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@banterCZ banterCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jandusil jandusil linked an issue Oct 24, 2023 that may be closed by this pull request
Executable war #278
Closed
jandusil
jandusil approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@jandusil jandusil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@jnpsk jnpsk merged commit 2144346 into develop Oct 24, 2023
4 checks passed
@jnpsk jnpsk deleted the issues/278-executable-war branch October 25, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jandusil jandusil jandusil approved these changes

@banterCZ banterCZ banterCZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Executable war
3 participants
@jnpsk @banterCZ @jandusil