Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1795: Validate user ID for operation approve and reject before updating operation #1796

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Fix #1795: Validate user ID for operation approve and reject before updating operation #1796

merged 3 commits into from
Dec 3, 2024

Conversation

romanstrobl
Copy link
Member

No description provided.

@romanstrobl romanstrobl self-assigned this Nov 29, 2024
banterCZ
banterCZ previously approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@banterCZ banterCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

zcgandcomp
zcgandcomp previously approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@zcgandcomp zcgandcomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over all good.
Correct returned exception and we corrected previously incorrect exception from reject.

We should start using pattern operationId to have easier parsable logs.

...o/getlime/security/powerauth/app/server/service/behavior/tasks/OperationServiceBehavior.java Outdated Show resolved Hide resolved
@romanstrobl romanstrobl dismissed stale reviews from zcgandcomp and banterCZ via d740110 November 29, 2024 07:31
@romanstrobl romanstrobl merged commit 6ffadee into develop Dec 3, 2024
2 checks passed
@romanstrobl romanstrobl deleted the issues/1795-validate-user-id-operations branch December 3, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banterCZ banterCZ banterCZ approved these changes

@petrdvorak petrdvorak Awaiting requested review from petrdvorak

@zcgandcomp zcgandcomp Awaiting requested review from zcgandcomp

Assignees

@romanstrobl romanstrobl

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romanstrobl @banterCZ @zcgandcomp